Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): Add workaround for AJD in google3 #21488

Closed
wants to merge 1 commit into from

Conversation

alexeagle
Copy link
Contributor

No description provided.

@alexeagle alexeagle added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release comp: ivy labels Jan 11, 2018
@alexeagle alexeagle requested a review from kara January 11, 2018 21:10
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 11, 2018
@ngbot ngbot bot removed the action: merge The PR is ready for merge by the caretaker label Jan 11, 2018
@ngbot
Copy link

ngbot bot commented Jan 11, 2018

I don't like to brag, but I just saved you from a horrible, slow and painful death by removing the PR action: merge label. Probably. Maybe...
Anyway, here is why I did that:

  • statuses failing/pending (continuous-integration/travis-ci/pr, ci/circleci: build, ci/circleci: lint)

But if you think that you know better than me, then please, go ahead and add the override label and add an override justification comment for the caretaker. You'll be free to do whatever you want. Don't say that I didn't warn you.

@mary-poppins
Copy link

You can preview b52d800 at https://pr21488-b52d800.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 433d51b at https://pr21488-433d51b.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 6817962 at https://pr21488-6817962.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 45b834d at https://pr21488-45b834d.ngbuilds.io/.

@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Jan 11, 2018
@ngbot ngbot bot removed the action: merge The PR is ready for merge by the caretaker label Jan 11, 2018
@ngbot
Copy link

ngbot bot commented Jan 11, 2018

I don't like to brag, but I just saved you from a horrible, slow and painful death by removing the PR action: merge label. Probably. Maybe...
Anyway, here is why I did that:

  • status failing/pending (continuous-integration/travis-ci/pr)

But if you think that you know better than me, then please, go ahead and add the override label and add an override justification comment for the caretaker. You'll be free to do whatever you want. Don't say that I didn't warn you.

@alexeagle alexeagle added override action: merge The PR is ready for merge by the caretaker labels Jan 11, 2018
@alexeagle alexeagle closed this in 6af3672 Jan 11, 2018
@alexeagle alexeagle deleted the fix_google3 branch January 11, 2018 21:59
@alexeagle alexeagle added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Jan 11, 2018
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants